🐛 The dependent cell is now linked correctly to the simulation base number in SiDB simulation #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drewniok
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 96.07% 96.02% -0.05%
==========================================
Files 100 100
Lines 9963 9968 +5
==========================================
Hits 9572 9572
- Misses 391 396 +5
☔ View full report in Codecov by Sentry. |
marcelwa
approved these changes
Nov 7, 2023
|
@Drewniok thanks for fixing this so quickly! Would you mind changing the name of the PR slightly? It should not state what was previously the case but what you have implemented, e.g., "🐛 The dependent cell is now linked correctly to the simulation base number in QuickExact". |
Drewniok
changed the title
|
@Drewniok I have no idea why the |
marcelwa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the dependent cell can be positively charged even if the base number is set to two-state simulation.
@wlambooy Thanks for reporting this bug.
Checklist: